Precommit: run mypy on all files, including tests. #283

fzimmermann89 · 2024-05-12T12:51:01Z

Runs mypy on all files. As changes to one file can cause typing issues in unchanged files.

[ghstack-poisoned]

fzimmermann89 · 2024-05-12T12:51:02Z

Stack from ghstack (oldest at bottom):

github-actions · 2024-05-12T12:53:08Z

Coverage Report

File	Stmts	Miss	Cover	Missing
src/mrpro/algorithms/csm
_iterative_walsh.py	15	1	93%	34
src/mrpro/algorithms/optimizers
_adam.py	17	1	94%	82
src/mrpro/algorithms/reconstruction
_direct_reconstruction.py	63	36	43%	53–58, 75–83, 95–97, 113–120, 134–145
_reconstruction.py	10	1	90%	20
src/mrpro/data
_AcqInfo.py	83	2	98%	100, 138
_CsmData.py	21	3	86%	28, 72–74
_DcfData.py	91	5	95%	36, 42, 86, 111, 199
_IData.py	61	3	95%	136, 142, 146
_IHeader.py	59	2	97%	80, 107
_KHeader.py	127	9	93%	37, 84, 122, 167, 178, 185–186, 189, 196
_KNoise.py	22	9	59%	54–67
_MoveDataMixin.py	133	14	89%	36, 130, 146, 160–162, 223, 286, 300, 379, 399–400, 417–418
_QData.py	31	1	97%	56
_SpatialDimension.py	46	1	98%	80
_TrajectoryDescription.py	14	1	93%	38
src/mrpro/data/_kdata
_KData.py	108	7	94%	104–105, 175–176, 218, 223–224
_KDataRemoveOsMixin.py	30	2	93%	53, 55
_KDataSelectMixin.py	22	2	91%	62, 78
_KDataSplitMixin.py	51	3	94%	67, 97, 106
src/mrpro/data/traj_calculators
_KTrajectoryCalculator.py	27	2	93%	40, 62
_KTrajectoryIsmrmrd.py	16	2	88%	58, 67
_KTrajectoryPulseq.py	30	1	97%	69
src/mrpro/operators
_CartesianSamplingOp.py	50	9	82%	63–64, 69–70, 75–76, 102, 105, 128
_ConstraintsOp.py	61	2	97%	38, 40
_EndomorphOperator.py	57	3	95%	219, 223, 227
_FastFourierOp.py	31	2	94%	84, 94
_FourierOp.py	78	1	99%	146
_GridSamplingOp.py	123	9	93%	74–75, 84–85, 92–93, 96, 98, 100
_LinearOperator.py	64	3	95%	41, 142, 147
_Operator.py	56	1	98%	38
_SliceProjectionOp.py	168	8	95%	55, 62, 64, 70, 192, 213, 246, 286
_ZeroPadOp.py	16	1	94%	44
src/mrpro/utils
_Rotation.py	457	30	93%	60–70, 110, 287, 373, 375, 388, 445, 450, 453, 468, 484, 488, 633, 638, 641, 656, 659, 734, 736, 744–745, 985, 1067
_split_idx.py	10	2	80%	57, 61
_zero_pad_or_crop.py	31	6	81%	40, 44, 68, 71, 74, 77
filters.py	68	6	91%	48–50, 75, 80, 87
slice_profiles.py	45	6	87%	31, 47, 124–127, 160
sliding_window.py	35	1	97%	47
TOTAL	3207	198	94%

Tests	Skipped	Failures	Errors	Time
656	0 💤	0 ❌	0 🔥	1m 0s ⏱️

fzimmermann89 · 2024-05-12T12:59:44Z

As changes to a file can also lead to type errors in other files, only checking committed files does not help.
Also, a lot of non-commited files will be parsed by mypy anyways, if they are imported. Overall, mypy suggested to run on all files
python/mypy#13916

As #282 fixes all remaining issues in the tests, we can now also check the tests.

[ghstack-poisoned]

fzimmermann89 · 2024-05-12T17:26:08Z

Mypy cannot infer that the nullcontext or pytest.warns condition always results in a context manager.

This either needs a type hint or a different logic.

python/mypy#10109

--> fixed in #282

[ghstack-poisoned]

fzimmermann89 · 2024-05-22T22:16:14Z

The only issue now is, that if you have some non-staged files with typing issues in the src directory,
the precommit will fail...

not sure if there is an easy way to run on 'staged and already committed files' in precommit..

[ghstack-poisoned]

ghstack-source-id: 0f7ce8094f8f592286fe8c0a2193dac831881d50 ghstack-comment-id: 2106237133 Pull Request resolved: #283

Changes to one file can cause mypy failures in non-changed files.

fzimmermann89 added 14 commits May 11, 2024 15:36

Update

b28d529

[ghstack-poisoned]

Update

41c660d

[ghstack-poisoned]

Update

a3fab1b

[ghstack-poisoned]

Update

0b2089b

[ghstack-poisoned]

Update

b78ce06

[ghstack-poisoned]

Update

4918ef0

[ghstack-poisoned]

Update

17fd871

[ghstack-poisoned]

Update

f9efb4e

[ghstack-poisoned]

Update

ff4d9cb

[ghstack-poisoned]

Update

ccd1ca2

[ghstack-poisoned]

Update

0564941

[ghstack-poisoned]

Update

f4be0f7

[ghstack-poisoned]

Update

80bae5d

[ghstack-poisoned]

Update

cc26c96

[ghstack-poisoned]

This was referenced May 12, 2024

Bump pytorch and ismrmrd version #281

Merged

Unify .to / .cpu / .cuda for data classes #279

Merged

Add EndomorphOperator #280

Merged

Fix types #282

Merged

fzimmermann89 requested a review from schuenke May 12, 2024 12:59

fzimmermann89 added 4 commits May 12, 2024 17:03

Update

d9f4673

[ghstack-poisoned]

Update

5fec475

[ghstack-poisoned]

Update

e8e45cb

[ghstack-poisoned]

Update

36992b7

[ghstack-poisoned]

Update

76c28d7

[ghstack-poisoned]

fzimmermann89 added 2 commits May 22, 2024 22:05

Update

37eb0bb

[ghstack-poisoned]

Update

10a1c76

[ghstack-poisoned]

fzimmermann89 added 2 commits May 22, 2024 22:12

Update

1041ca7

[ghstack-poisoned]

Update

98bfa74

[ghstack-poisoned]

fzimmermann89 added 4 commits May 25, 2024 01:02

Update

4bfcad9

[ghstack-poisoned]

Update

0b82ef3

[ghstack-poisoned]

Update

88f2ded

[ghstack-poisoned]

Update

d0983c9

[ghstack-poisoned]

fzimmermann89 added 4 commits May 27, 2024 17:22

Update

1374cb2

[ghstack-poisoned]

Update

5bf719e

[ghstack-poisoned]

Update

9337edf

[ghstack-poisoned]

Update

0f52a79

[ghstack-poisoned]

fzimmermann89 added 4 commits May 27, 2024 18:35

Update

4d85384

[ghstack-poisoned]

Update

57a83e7

[ghstack-poisoned]

Update

cf2b71c

[ghstack-poisoned]

Update

fba1436

[ghstack-poisoned]

fzimmermann89 added a commit that referenced this pull request May 27, 2024

Precommit: run mypy on all files, including tests.

ca8064e

ghstack-source-id: 0f7ce8094f8f592286fe8c0a2193dac831881d50 ghstack-comment-id: 2106237133 Pull Request resolved: #283

Base automatically changed from gh/fzimmermann89/25/head to main May 27, 2024 20:45

Merge branch 'main' into gh/fzimmermann89/26/head

2dbc678

fzimmermann89 merged commit 5540525 into main May 27, 2024
15 checks passed

fzimmermann89 deleted the gh/fzimmermann89/26/head branch May 27, 2024 20:51

schuenke mentioned this pull request May 31, 2024

No error for missing doc strings #296

Closed

fzimmermann89 added a commit that referenced this pull request Nov 10, 2024

Precommit: run mypy on all files, including tests. (#283)

3acd6e1

Changes to one file can cause mypy failures in non-changed files.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precommit: run mypy on all files, including tests. #283

Precommit: run mypy on all files, including tests. #283

fzimmermann89 commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 12, 2024 •

edited

Loading

github-actions bot commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 12, 2024

fzimmermann89 commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 22, 2024 •

edited

Loading

Precommit: run mypy on all files, including tests. #283

Precommit: run mypy on all files, including tests. #283

Conversation

fzimmermann89 commented May 12, 2024 • edited Loading

fzimmermann89 commented May 12, 2024 • edited Loading

github-actions bot commented May 12, 2024 • edited Loading

fzimmermann89 commented May 12, 2024

fzimmermann89 commented May 12, 2024 • edited Loading

fzimmermann89 commented May 22, 2024 • edited Loading

fzimmermann89 commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 12, 2024 •

edited

Loading

github-actions bot commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 12, 2024 •

edited

Loading

fzimmermann89 commented May 22, 2024 •

edited

Loading